Fix radio and checkbox keyboard handling in .btn-group #16404
Conversation
Fix for problem that emerged from #16226 (`.active` class not actually being applied) and expansion of the script to also correctly handle keyboard interaction with checkboxes in `data-toggle="button"` groups
Overall logic for this test appears broken, possibly relating to an older version of Bootstrap that did not require explicit `data-toggle="button"` on single toggle buttons?
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 0c1daaf (Please note that this is a fully automated comment.) |
|
Ok, I may jump the gun a bit (instead of waiting for review), but as the current state of radio buttons/checkboxes for keyboard users is essentially broken (and not really fixed by my previous PR, which was merged), I'd like to fasttrack this fix (I'm more concerned about potentially removing a unit test that is, in fact, still needed...but from my research above it doesn't appear to; happy to eat humble pie later and undo that particular removal if it turns out I was wrong) |
…e-fix Fix radio and checkbox keyboard handling in .btn-group
Fix for problem that emerged from #16226 (
.activeclass not actuallybeing applied) and expansion of the script to also correctly handle
keyboard interaction with checkboxes in
data-toggle="buttons"groupsAlso includes removal of an apparently broken/vestigial unit test which tested a scenario not covered by our documentation (and logic)