Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Closes #16447] Manually add license to bootstrap.less #16457

Merged
merged 1 commit into from
May 14, 2015
Merged

[Closes #16447] Manually add license to bootstrap.less #16457

merged 1 commit into from
May 14, 2015

Conversation

kkirsche
Copy link
Contributor

[Closes #16447] Concat. license to bootstrap.less

EDIT: WIP Fixed and verified

@mdo
Copy link
Member

mdo commented May 12, 2015

Problem is this needs to be added without compilation, as in without our Gruntfile. The original bug report —I think—is mentioning that if you use a regular compiler, there's no license.

@kkirsche
Copy link
Contributor Author

Ah, sorry, I misunderstood that. I'll add it in manually instead then I guess unless you have an alternative solution which I could implement?

@cvrebert
Copy link
Collaborator

I agree that manual is probably the way to go here.

@mdo
Copy link
Member

mdo commented May 12, 2015

Manual works for me.

@kkirsche
[Closes twbs#16447] Concat. license to bootstrap.less
25dcaf4 
[Closes twbs#16447] Concat. license to bootstrap.less
@kkirsche
Copy link
Contributor Author

@mdo / @cvrebert Fixed

@kkirsche kkirsche changed the title [Closes #16447] Concat. license to bootstrap.less [Closes #16447] Manually add license to bootstrap.less May 12, 2015
@kkirsche
Copy link
Contributor Author

Wanted to follow up on this and see if there was anything missing / needed to be added (sorry for the partial email, hit enter by accident)

@mdo mdo added this to the v3.3.5 milestone May 14, 2015
mdo added a commit that referenced this pull request May 14, 2015
@mdo
Merge pull request #16457 from kkirsche/patch-8
504c90d 
[Closes #16447] Manually add license to bootstrap.less
@mdo mdo merged commit 504c90d into twbs:master May 14, 2015
@cvrebert cvrebert mentioned this pull request May 14, 2015
Closed
@kkirsche kkirsche deleted the patch-8 branch May 14, 2015 12:48
@XhmikosR
Copy link
Member

This causes duplicate license headers in the dist CSS files.

@cvrebert
Copy link
Collaborator

Yes, the part of the Gruntfile that previously added the license header needs to be killed.

@XhmikosR
Copy link
Member

I ended up just running grunt-usebanner for the theme files only.

XhmikosR added a commit that referenced this pull request May 16, 2015
@XhmikosR
Only run grunt-usebanner for the theme CSS files.
c0548e6 
We ended up with duplicate license header after #16457.
XhmikosR added a commit that referenced this pull request May 16, 2015
@XhmikosR
Only run grunt-banner for the theme CSS files.
9bf656b 
We ended up with duplicate license header for the main CSS after #16457.
@XhmikosR XhmikosR mentioned this pull request May 16, 2015
Merged
@kkirsche
Copy link
Contributor Author

Oops. Sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build css meta
Projects
None yet
Milestone
v3.3.5
Development

Successfully merging this pull request may close these issues.

Include license to bootstrap.less
4 participants
@kkirsche @mdo @cvrebert @XhmikosR