Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #17555][V4] fix resetting style on closing collapse #17568

Merged
merged 1 commit into from
Oct 10, 2016
Merged

[Fix #17555][V4] fix resetting style on closing collapse #17568

merged 1 commit into from
Oct 10, 2016

Conversation

Johann-S
Copy link
Member

Hi,

it's a fix for #17555

@Johann-S
Copy link
Member Author

Sorry @cvrebert to PING you but I made my PR a long time ago (13 days) and nobody reviewed it

@cvrebert
Copy link
Collaborator

CC: @fat

@maniqui
Copy link

maniqui commented Nov 11, 2015

I can confirm this pull request fixes an issue with Collapse not removing a "leftover" inline style (style="height: 0") after collapsing. After a navbar has been expanded and then collapsed, this leftover inline style will break the layout, when changing the viewport width (for example, by maximizing the window).

@Johann-S
Copy link
Member Author

Thanks for your support @maniqui 😄

@mdo mdo added this to the v4.0.0-alpha.5 milestone Oct 10, 2016
@mdo mdo merged commit 4d725c9 into twbs:v4-dev Oct 10, 2016
@mdo mdo mentioned this pull request Oct 10, 2016
@Johann-S
Copy link
Member Author

Thank you @mdo 👍

@Johann-S Johann-S deleted the fixCollapseHeight branch October 10, 2016 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants