Fix bug #16980

[phmasek]

Added a check if there are more than one tab active, make the one with highest index inactive.

[twbs-savage]

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 7c089f3
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/82766255

(Please note that this is a fully automated comment.)

[phmasek]

Seems like an unsuccessful test in something unrelated to my fix. In Mac OS X, Safari.

Tested on local computer (Mac OS X, Safari) with full success.

[cvrebert]

@twbs-savage Retry

[twbs-savage]

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 7c089f3
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/82780525

(Please note that this is a fully automated comment.)

[cvrebert]

@Pletron Please add a relevant unit test to the test suite. See https://github.com/twbs/bootstrap/tree/master/js/tests for details.

[phmasek]

@cvrebert There is an issue with creating a unit test for this particular bug fix. The fix addresses an issue that can only be replicated when running a .click() event. However, running such an event is not possible in the test suite (see image). The workaround is to run $('#tab-button').bootstrapTab('show'), but this does not replicate the issue.

I can write the unit test with the workaround, but it is completely obsolete for this purpose. What do you suggest?

[cvrebert]

Use .trigger('click') instead of .click()
Example:

bootstrap/js/tests/unit/tab.js

Line 203 in 79cdd66

$tabs.find('li:last a').trigger('click')

[twbs-savage]

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 6386cf2f14853b3231b4540996b05d6bbdbb3cde
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/82790083

(Please note that this is a fully automated comment.)

[cvrebert]

Hmm, actually, sounds like this involves transitions, in which case a unit test won't work because the test suite runs with transitions disabled. Guess this will need to be a manual visual test (https://github.com/twbs/bootstrap/blob/master/js/tests/visual/tab.html ) instead.

[phmasek]

@cvrebert Yeah, tested it there with the existing code through the console and it works fine. How would you suggest that I write the test there?

To test i ran: $('#myTab1 > :eq(1) a').click();$('#myTab1 > :eq(0) a').click(); in the console. This triggers a quick switch between the tabs.

[twbs-savage]

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 7c089f3
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/82793802

(Please note that this is a fully automated comment.)

[cvrebert]

Add another section to /js/tests/visual/tab.html with a set of tabs and a button with a click handler that runs $('#myTab1 > :eq(1) a').click();$('#myTab1 > :eq(0) a').click();.

[twbs-savage]

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 8c1bfd7
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/82800632

(Please note that this is a fully automated comment.)

[cvrebert]

Sauce failure is due to an unrelated Sauce error.

[phmasek]

@cvrebert Yes, seems like issues with Sauce. Anything more I can do here?

[cvrebert]

No, just needs code review now.
CC: @fat

[cvrebert]

Sorry, got the PR numbers mixed up.

[mdo]

Bootstrap 3 is no longer being officially developed or supported.

All work has moved onto our next major release, v4. As such, this issue or pull request is being closed as a "won't fix." For additional help and support, we recommend utilizing our community resources. Thanks for your understanding, and see you on the other side of v4!

<3,
@mdo and team