Add top border to card header if the header isn't the first child #18217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a card to have multiple headers. I chose to do this rather than add a sub-header class.
cvrebert
changed the title
|
I could see this backfiring where some random hidden element would cause this to glitch out. Thanks, but we'll pass for now on making this default behavior. |
|
I considered that when I submitted this but I saw it being identical in constraint of use as the classes that add borders on last-child. For example add an hidden element after a footer and it will screw the borders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a card to have multiple headers.
I chose to do this rather than add a sub-header class.