Have same margin for <hN> as a <div> on .card-headers #19048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related #18726 When you use a `<hN>` as `.card-header` there is `margin-bottom: .5rem` added. The changes set the margin-bottom to 0
| @@ -71,6 +71,7 @@ | |||
| .card-header { | |||
| @include clearfix; | |||
| padding: $card-spacer-y $card-spacer-x; | |||
| margin-bottom: 0; // Removes the default margin-bottom of <hN> | |||
This was referenced Sep 12, 2016
Closed
|
Merged this for now, but I may come back to revert this and similar changes in favor of margin utilities that can easily remove the |
|
Hey, @mkroeders & @mdo, given the default appearance seems to require zero margin, might it be preferable to just set all margins with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #18726
When you use a
<hN>as.card-headerthere ismargin-bottom: .5remadded. The changes set the margin-bottom to 0