Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltip.js #19541

Merged
merged 2 commits into from
Dec 22, 2016
Merged

Update tooltip.js #19541

merged 2 commits into from
Dec 22, 2016

Commits on Mar 14, 2016

  1. Update tooltip.js 

    Don't reference `Tether` via attachment to `window`, with the update one can import bootstrap providing the dependencies in webpack with:

```
new webpack.ProvidePlugin({
  $: 'jquery',
  jQuery: 'jquery',
  Tether: 'tether',
});
```

Then inside one's own bootstrap/globals, `import 'bootstrap';` will simply work, and $/jQuery can be used from there.

I had wanted to do this, but also expose jQuery, Tether, etc when in development build in my code, but if I provide `window.Tether`, I can't then expose it to the outside...
    @tracker1
    tracker1 committed Mar 14, 2016
    Configuration menu
    Copy the full SHA
    1a23279 View commit details
    Browse the repository at this point in the history

  2. Update tooltip.js 

    match project's style check
    @tracker1
    tracker1 committed Mar 14, 2016
    Configuration menu
    Copy the full SHA
    681d390 View commit details
    Browse the repository at this point in the history