alert.js: Avoid calling jQuery('#'), it's a syntax error in jQuery 3.0

[dmethvin]

No description provided.

[twbs-savage]

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: dd77ecc
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/134788284

(Please note that this is a fully automated comment.)

[cvrebert]

@dmethvin Is there a plausible scenario where this could occur that doesn't involve user error?

[XhmikosR]

I wonder if this is the same error $('a[href*=#].

[dmethvin]

Is there a plausible scenario where this could occur that doesn't involve user error?

I'm honestly not sure but since it was happening in a unit test I assumed it might be done by users as well.

I wonder if this is the same error $('a[href*=#].

No, although that is also an invalid CSS selector. Special characters in attribute values must be quoted, per the spec.

[XhmikosR]

No, although that is also an invalid CSS selector. Special characters in attribute values must be quoted, per the spec.

Agreed, it's just that it stop working in a patch version build so it was a little unexpected :/

Now, about this PR, do you think you can add a test for this case?

[dmethvin]

Now, about this PR, do you think you can add a test for this case?

It was failing an existing test case before this PR, so I figured that fixing that one was enough. The failing test has this markup.

[XhmikosR]

Oh, cool. Then I have no objection in merging this. @cvrebert push the button if you agree.

[cvrebert]

The current v3 docs don't use the <a class="close" href="#" data-dismiss="alert"> markup anywhere. v3.0.0's docs had it in one place, where the live demo and the syntax-highlighted code were out of sync 😢

On account of compatibility paranoia, I'm okay with merging this.