Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for heading sizes #20646

Merged
merged 3 commits into from
Sep 8, 2016
Merged

Fix docs for heading sizes #20646

merged 3 commits into from
Sep 8, 2016

Conversation

TiGR
Copy link
Contributor

@TiGR TiGR commented Sep 6, 2016

Sizes here were from v3. Fixed these to correspond with v4 (for real).

Should rem sizes be also added to docs?

Sizes here were from v3. Fixed these to correspond with v4 (for real).

Should rem sizes be also added to docs?
@schoenburg
Copy link

I was looking at this discrepancy today too and I was trying to figure out which was wrong, the docs or the code base? Seems like the sizes in the code are a bit big, but if those are correct than this is definitely a great fix.

Also agree it's a good idea to update with the rem values as well since that is how they are coded.

@outdooricon
Copy link

yes, the rems are great!

@TiGR
Copy link
Contributor Author

TiGR commented Sep 6, 2016

Added rem sizes, not sure about if this is intended behavior (I mean the sizes). Anyway, its up to maintainers to decide.

@schoenburg
Copy link

schoenburg commented Sep 6, 2016

The rems are based off of an assumed 16px value for most browsers, and is at this time actually explicitly set to that in the styles, so some of these values are a bit off.

h1 and h2 are correct.

h3, .h3 is 1.75rem so should be 28px

h4, .h4 is 1.5rem so should be 24px

h5, .h5 is 1.25rem so should be 20px

h6, .h6 is 1rem so should be 16px

@TiGR
Copy link
Contributor Author

TiGR commented Sep 6, 2016

Not sure how I was able to mess this up - I remember calculating these numbers, but somehow ended up writing line-heights instead of these...

@mdo mdo added this to the v4.0.0-alpha.5 milestone Sep 8, 2016
@mdo mdo merged commit 18258cb into twbs:v4-dev Sep 8, 2016
@mdo
Copy link
Member

mdo commented Sep 8, 2016

Thanks!

@mdo mdo mentioned this pull request Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants