Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Social meta tags #20825

Merged
merged 10 commits into from
Oct 3, 2016
Merged

v4: Social meta tags #20825

merged 10 commits into from
Oct 3, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Oct 2, 2016

This supersedes #20702, but still fixes #18437.

I found the Jekyll SEO plugin stuff wasn't working right, and having a quick glance at other sites, I realized things were feeling just a tad complicated. Rather than rely on another plugin, this handles it directly in a partial.

I've added description frontmatter for all the pages and included that where appropriate. Also in this PR is two quick images for the Twitter cards (square for most pages, big one for home page).

@mdo mdo added this to the v4.0.0-alpha.5 milestone Oct 2, 2016
@mdo mdo merged commit 7bf868a into v4-dev Oct 3, 2016
@mdo mdo deleted the v4-social branch October 3, 2016 01:19
@mdo mdo mentioned this pull request Oct 3, 2016
@XhmikosR
Copy link
Member

XhmikosR commented Oct 3, 2016

Why didn't you use jekyll-social-tag?

@mdo
Copy link
Member Author

mdo commented Oct 3, 2016

Couldn't get the images to work, didn't feel I needed all those meta tags, and wanted more fine grained control over the type of cards shown.

@XhmikosR
Copy link
Member

XhmikosR commented Oct 3, 2016

Well, the plugin aims to make things simpler and more correct. Why reinvent the wheel if we can use something that works already? That being said, I've had issues with the plugin too. But, everyone will benefit if you could report your issues upstream, so that eventually we can use it.

@bardiharborow
Copy link
Member

bardiharborow commented Oct 3, 2016

@XhmikosR, I looked at the template that jekyll-social-tag uses and it's simply not flexible enough. Even getting <title>s to work correctly took a bit of a hack when I tried it.

Given this section in the readme, I'm not sure if there's much we can do about it:

Jekyll SEO tag isn't designed to accommodate every possible use case. It should work for most site out of the box and without a laundry list of configuration options that serve only to confuse most users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants