Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexbox grid updates #20829

Merged
merged 4 commits into from
Oct 3, 2016
Merged

Flexbox grid updates #20829

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d3ae88
Fixes #20775 without adding extra width and an important flag
mdo Oct 3, 2016
1d9265b
Since we're now getting the extend, we don't need the extra position …
mdo Oct 3, 2016
7306e0b
rerrange
mdo Oct 3, 2016
5f7e3b3
getting min-height from the extend already
mdo Oct 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scss/mixins/_grid-framework.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@
@each $breakpoint in map-keys($breakpoints) {
$breakpoint-counter: ($breakpoint-counter + 1);

// Allow columns to stretch full width below their breakpoints
.col-#{$breakpoint} {
@extend %grid-column;
}

@for $i from 1 through $columns {
.col-#{$breakpoint}-#{$i} {
@extend %grid-column;
Expand All @@ -31,11 +36,9 @@
// Provide basic `.col-{bp}` classes for equal-width flexbox columns
@if $enable-flex {
.col-#{$breakpoint} {
position: relative;
flex-basis: 0;
flex-grow: 1;
max-width: 100%;
min-height: 1px;
}
}

Expand Down