Match the height of select.form-control with input.form-control #20874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2016
Closed
This was referenced Oct 10, 2016
|
@mdo Think there's a new bug in Chrome related to some stuff here, I noticed some custom selects of my own in a non-Bootstrap project had busted heights, then stumbled across this commit of yours. I assume when you committed this 4 days ago, all three of these were the same height yeah?
😩 |
|
Looking at latest Chrome on macOS, I still see things looking as intended.
|
|
Somehow I was a bit behind, updated and all good now, thanks 👊🏻 |
|
This is still fucked in Chrome on Windows. Not everyone uses a Mac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a local variable and some calc love to counteract the border-width (times 2) from the height of the select. Fixes #17194 and nullifies #19967.
Demo of the new CSS in effect with inputs, selects, and custom selects for good measure: https://jsbin.com/yitijo/.