Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom QUnit-PhantomJS bridge. #21003

Closed
wants to merge 1 commit into from
Closed

Remove custom QUnit-PhantomJS bridge. #21003

wants to merge 1 commit into from

Conversation

bardiharborow
Copy link
Member

The file is effectively the same as the default, except for a .bind() polyfill, which is unnecessary now that we have dropped IE8.

@mdo
Copy link
Member

mdo commented Oct 26, 2016

Can I get a review from @cvrebert or @Johann-S?

@mdo mdo modified the milestone: v4.0.0-alpha.6 Oct 26, 2016
@Johann-S
Copy link
Member

If you remove the bridge QUnit result will be :

image

Instead of :

image

Which is less verbose than with the bridge.

But yes it's interesting to remove the bind polyfill but I'm not sure about the Phantom Bridge which allow us to have more details on tests results.

@bardiharborow
Copy link
Member Author

Hmm. I missed that. Not sure whether being slightly more verbose warrants the extra file, especially given how quiet the other build commands are already.

A failing test looks like this. Seems like there is still plenty of verboseness when something goes wrong.

Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of delete this file why not convert it to ES6 @bardiharborow ?

@bardiharborow
Copy link
Member Author

Punting on this for right now due to concerns by @Johann-S. I'll revisit later.

@Johann-S
Copy link
Member

Johann-S commented Nov 2, 2016

Sorry I thought you transformed all our JS tests in ES6 but it's not the case. But yes I'm not sure of the interest of this PR except the removal of the bind polyfill

@bardiharborow bardiharborow deleted the bridge branch November 3, 2016 00:51
@bardiharborow bardiharborow restored the bridge branch November 3, 2016 00:51
@mdo mdo removed this from the v4.0.0-alpha.6 milestone Nov 17, 2016
@bardiharborow bardiharborow mentioned this pull request Jan 18, 2017
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants