-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom QUnit-PhantomJS bridge. #21003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of delete this file why not convert it to ES6 @bardiharborow ?
Punting on this for right now due to concerns by @Johann-S. I'll revisit later. |
Sorry I thought you transformed all our JS tests in ES6 but it's not the case. But yes I'm not sure of the interest of this PR except the removal of the |
The file is effectively the same as the default, except for a
.bind()
polyfill, which is unnecessary now that we have dropped IE8.