Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Switch to jQuery Slim #21466

Merged
merged 6 commits into from
Dec 31, 2016
Merged

v4: Switch to jQuery Slim #21466

merged 6 commits into from
Dec 31, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Dec 29, 2016

This supersedes #20203, changing our jQuery version to the latest slim version while updating our examples to match the new CDN and what not.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Dec 29, 2016
@Starsam80
Copy link
Contributor

I think docs/assets/js/vendor/jquery.min.js and js/tests/vendor/jquery.min.js need to be updated as well

@mdo
Copy link
Member Author

mdo commented Dec 29, 2016

Hmm, wonder if we need to keep those js/tests/vendor/ copies around? I feel like we should be able to reference the docs copies so we don't have duplicate files.

@bardiharborow
Copy link
Member

js/tests/vendor/jquery.min.js is only referenced in js/tests/index.html, so I suppose you could use ../../docs/assets/js/vendor/jquery.min.js. If you do this, you should do the same to Tether.

@bardiharborow
Copy link
Member

bardiharborow commented Dec 31, 2016

You're missing js/tests/index.html#L9-L10, and then LGTM.

@mdo mdo merged commit d935cca into v4-dev Dec 31, 2016
@mdo mdo deleted the jquery-slim branch December 31, 2016 08:52
@mdo mdo mentioned this pull request Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants