Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrapping card decks #22289

Merged
merged 2 commits into from
Mar 28, 2017
Merged

Fix wrapping card decks #22289

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41f60ad
fixes #22007 and fixes #21976 by changing margin strategy for card de…
mdo Mar 28, 2017
0ad0c81
order
mdo Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions scss/_card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,17 +188,15 @@
.card-deck {
display: flex;
flex-flow: row wrap;
margin-left: -$card-deck-margin;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered display, flex-flow, margin-right, margin-left

margin-right: -$card-deck-margin;

.card {
display: flex;
flex: 1 0 0;
flex-direction: column;

// Selectively apply horizontal margins to cards to avoid doing the
// negative margin dance like our grid. This differs from the grid
// due to the use of margins as gutters instead of padding.
&:not(:first-child) { margin-left: $card-deck-margin; }
&:not(:last-child) { margin-right: $card-deck-margin; }
margin-left: $card-deck-margin;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered display, flex, flex-direction, margin-right, margin-left

margin-right: $card-deck-margin;
}
}
}
Expand Down