Remove system-ui from font stack due to i18n issues #22377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehni
added a commit
to ditojs/dito
that referenced
this pull request
Mar 8, 2019
1 task
Matthewrbowker
pushed a commit
to phorgeit/phorge
that referenced
this pull request
Oct 9, 2022
Summary: `system-ui` is provided by modern browsers as [a cross-platform default font](https://caniuse.com/font-family-system-ui). Using this font [was a controversial choice back in 2017](https://infinnie.github.io/blog/2017/systemui.html). because it did not address i18n well and therefore it was removed from Bootstrap [twbs/bootstrap#22377](twbs/bootstrap#22377). However, it was added back in Bootstrap v5 [twbs/bootstrap#30561](twbs/bootstrap#30561) since it got better over time. Fixes T15049. Test Plan: Tested locally for now. Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: Matthew, avivey, Cigaryno, 20after4, Ekubischta, speck, tobiaswiese, valerio.bozzolan Maniphest Tasks: T15049 Differential Revision: https://we.phorge.it/D25021
|
system-ui seems to have made it back into the latest release bootstrap/scss/_variables.scss Line 606 in 72d3b6e |
|
That's a good thing: the i18n concern around Chinese is unfounded. |
|
It’s still a cross-platform concern. On Linux with no desktop environment, there is not even a way to set that. Please do not use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
system-uicauses all sorts of issues. This PR removes it for now, reverting #21356 and closing #22328.