Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-align to <body> so we can inherit it in <th>s #22858

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Conversation

mdo
Copy link
Member

@mdo mdo commented Jun 18, 2017

This sets an explicit text-align on the <body> element so we can use inherit to override the default <th> text-align value. Most browsers center this text, so we previously applied a specific text-align: left to the <th>s. That had a side effect of not responding in the same way as <td>s do when setting an alignment value on the <table>.

Fixes #22519.

@mdo mdo mentioned this pull request Jun 18, 2017
@mdo mdo merged commit 09019a8 into v4-dev Aug 11, 2017
@mdo mdo mentioned this pull request Aug 11, 2017
@mdo mdo deleted the th-text-align branch August 11, 2017 05:44
@mkamensky
Copy link

Would it be possible to change this into text-align: start? Otherwise it breaks things on RTL pages (generally speaking, it would help to change all the left/right into start/end, respectively)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants