Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and switch to using NPM lockfiles. #23094

Merged
merged 3 commits into from
Jul 16, 2017
Merged

Conversation

bardiharborow
Copy link
Member

@bardiharborow bardiharborow commented Jul 15, 2017

I'm happy to expand on my rationale for NPM lockfiles if needed, but basically they don't ship when publishing to NPM (and hence don't need to be moved to a subdirectory like shrinkwraps), and integrate very nicely with npm update.

Closes #22744.

@Johann-S
Copy link
Member

Overlapping with : #22744

@bardiharborow bardiharborow merged commit 028863d into v4-dev Jul 16, 2017
@bardiharborow bardiharborow deleted the deps branch July 16, 2017 03:51
@mdo mdo mentioned this pull request Jul 16, 2017
bardiharborow added a commit that referenced this pull request Jul 16, 2017
bardiharborow added a commit that referenced this pull request Jul 16, 2017
@XhmikosR
Copy link
Member

@bardiharborow: all is good, just one question. Why did you remove anchor etc? Aren't those used?

@XhmikosR
Copy link
Member

Also, I wanted to point out we should specify clean-css's compatibility for IE to be safe.

@bardiharborow
Copy link
Member Author

@XhmikosR I didn't (?). I've just updated anchor fromv3.2.2 to v4.0.0, etc.

Is there something with upgrading clean-css that I've missed?

@XhmikosR
Copy link
Member

You are right, it's just that someone had switched to the non-minified versions and now it's again the minified versions. It beats the point though because of the number of lines changed but anyway, maybe it won't happen again in the future.

Re clean-css: it's not exactly related to this PR; I just noticed that with the switch to npm scripts someone missed to specify the minimum IE compatibility option. This should be fixed asap to ensure we don't hit any weird issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants