Move jQuery and Popper to peerDependencies #23244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +66,8 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "dependencies": { | |||
There was a problem hiding this comment.
Is it necessary to keep an empty dependencies object in package.json?
There was a problem hiding this comment.
Probably not? I did to show we have no explicit dependencies...unsure what the best option is there.
There was a problem hiding this comment.
Oh ok, I'm unsure as well but just wanted to point that out, I don't think it is harmful to keep it there or to remove it.
There was a problem hiding this comment.
It's safe to remove dependencies if needed. Some of my libraries do that and it works just fine.
There was a problem hiding this comment.
Of course it's safe. It's left on purpose if you read the above comments, to indicate that there are no dependencies.
XhmikosR
approved these changes
Aug 8, 2017
Johann-S
approved these changes
Aug 8, 2017
bardiharborow
approved these changes
Aug 9, 2017
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23204.
I've made the change to
package.jsonas @bardiharborow suggested. I've also taken a quick pass at some docs updates to clarify usage around source files, compiled files, and that our JS plugins are optional and depend on jQuery and Popper.js.