FIX: Broken 'About' Link in the Footer #23367
Conversation
The `About` link in the footer is broken. This PR fixes that.  Hopefully, this will be my first contribution to _the_ Bootstrap project.
|
@XhmikosR Apologies for the tag, but this is a similar PR to the last one I submitted. The about link is also broken. |
|
Please try the latest v4-dev locally. Doesn't it work for you? I just don't
get all this because it works fine locally. The gh-pages is not up to date
not sure when Mark will update it.
…On Aug 12, 2017 22:39, "Ahmad Awais" ***@***.***> wrote:
@XhmikosR <https://github.com/xhmikosr> Apologies for the tag, but this
is a similar PR to the last one I submitted. The about link is also broken.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23367 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtRaJh6Q_jasXl2VODL7lzVuwyk1pks5sXf-PgaJpZM4O1f-C>
.
|
|
@XhmikosR I tried. I didn't work. Not sure why! But this one is the similar PR to the Example's broken link. At least it fixes the gh-pages branch — for now. |
|
But how can it not work when I clearly see the about page having the
redirect? I just want to understand why people keep having this with the
latest v4-dev branch locally. The live site is a separate thing.
…On Aug 12, 2017 22:47, "Ahmad Awais" ***@***.***> wrote:
@XhmikosR <https://github.com/xhmikosr> I tried. I didn't work. Not sure
why! But this one is the similar PR to the Example's broken link. At least
it fixes the gh-pages branch — for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23367 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtUZFd296iLtPOFb-UQWlYVS8xGRCks5sXgFIgaJpZM4O1f-C>
.
|
|
I am not sure. Have not seen what you guys are using to setup custom routing. First time here to contribute something. Been a regular core contributor at WordPress for years. |
|
Then how did you verify what I suggested above? Just check out the branch
to bundle install and bundle exec jekyll s and test locally. You should see
that about redirects just fine.
…On Aug 12, 2017 22:56, "Ahmad Awais" ***@***.***> wrote:
I am not sure. Have not seen what you guys are using to setup custom
routing. First time here to contribute something. Been a regular core
contributor at WordPress for years.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23367 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVVteKAh1oL1WvZ0DGSA2KRTeku9p_Nks5sXgN4gaJpZM4O1f-C>
.
|
|
I probably have a redirect on the live docs site that's interfering with anything we do in the |
|
I tried but I guess I wasn't able to build it correctly. Or maybe I did Though, it mimics the behavior which is here in the production. |
|
@mdo: how do you update the gh_pages branch? Just build from v4-dev and overwrite everything? If not, can you push any of your stuff that are not in v4-dev there so that we are in sync? And close/merge this, although I merged the examples patch even though locally it worked for me as it was. |
|
@XhmikosR I manually was updating some things, but I don't regularly push from |
The
Aboutlink in the footer is broken. This PR fixes that.Hopefully, this will be my first contribution to the Bootstrap project.