V4.1: Custom range control #23380
Closed
V4.1: Custom range control #23380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see my PR #19468, I'm sure you can take the styles for Firefox and Chrome for the equivalent of ::-ms-fill-lower |
|
@wolfy1339 i tried to make the element look the same accros browsers, that's why in didn't add styling for the progress like you did |
XhmikosR
reviewed
Aug 13, 2017
scss/_custom-forms.scss
Outdated
| } | ||
| } | ||
|
|
||
| &::-moz-focus-inner, &:-moz-focusring { |
There was a problem hiding this comment.
I think we have one rule per line so try updating your patch.
houndci-bot
reviewed
Aug 13, 2017
scss/_custom-forms.scss
Outdated
| &:active { | ||
|
|
||
| &::-webkit-slider-thumb, | ||
| &::-moz-range-thumb, |
scss/_custom-forms.scss
Outdated
|
|
||
| &:active { | ||
|
|
||
| &::-webkit-slider-thumb, |
scss/_custom-forms.scss
Outdated
| } | ||
| } | ||
|
|
||
| &::-moz-focus-inner, |
scss/_custom-forms.scss
Outdated
| outline: none; | ||
|
|
||
| &::-webkit-slider-thumb, | ||
| &::-moz-range-thumb, |
scss/_custom-forms.scss
Outdated
| &:focus { | ||
| outline: none; | ||
|
|
||
| &::-webkit-slider-thumb, |
XhmikosR
reviewed
Aug 13, 2017
scss/_custom-forms.scss
Outdated
| background-color: $custom-control-indicator-checked-bg; | ||
| border: 0; | ||
| border-radius: $custom-control-indicator-size; | ||
| -webkit-appearance: none; |
There was a problem hiding this comment.
I believe this should be unprefixed and let autoprefixer do its thing. The same goes for other prefixes.
|
@XhmikosR fixed it all :) |
This was referenced Feb 12, 2018
Merged
|
Conflicts resolved and a few more issues being tackled in #25600. Thanks for this, picking it up there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds styling to the range input type conform the BS custom control styling
i would like for people on windows to check this codepen: https://codepen.io/gijsbotje/pen/zddJXL
i've tried my best to get it uniform across browsers but i can't really test windows that good
hope you like it :)