Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove color property from badge class #23529

Merged
merged 1 commit into from
Aug 20, 2017

Commits on Aug 18, 2017

  1. Remove color property from badge class

    I suggest removing `color: #FFF` from the `badge` class, because it is
    provided by the `badge-<modifier>` classes along with a
    background-color, whereas there is no corresponding background-color
    provided on the `badge` class itself.
    
    Background
    ----------
    
    According to the documentation:
    
    > [badge] Requires one of the contextual, color modifier classes for `color` and
    > `background-color`.
    
    That is, color and background color should be provided by a modifier
    class, rather than the badge class itself.
    
    e.g. `<span class='badge badge-primary'>4</span>`
    
    In general, providing a `color` property without also providing a
    `background-color` should be avoided. [W3 QA tips]
    
    In this context, this is a problem only if someone creates a `badge`
    without providing a modifier. Such an omition may be difficult to trouble-shoot,
    because this will most likely yield white text on a white background.
    
    [W3 QA tips](https://www.w3.org/QA/Tips/color)
    Jon Wolski committed Aug 18, 2017
    Configuration menu
    Copy the full SHA
    f07d870 View commit details
    Browse the repository at this point in the history