Update which required jQuery release folks should use #23625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Johann-S: I'd say we should do this for all other places.
And maybe we should change the version range on package.json to reflect the fact that we need <4. |
|
That's true 👍 |
|
Is it ok for you now @XhmikosR ? |
XhmikosR
approved these changes
Aug 23, 2017
|
@mdo: not sure in which section to mention this change in the ship notes, so feel free to add it yourself. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already changed that in our
package.jsonso we should do the same and warn folks which do not use jQuery 3