Fix sticky margin when a modal is opened #23669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously white space was visible to the right of sticky elements due to right padding being added to the body. This fixes twbs#23661.
Johann-S
reviewed
Aug 25, 2017
| @@ -68,6 +68,7 @@ const Modal = (($) => { | |||
| DATA_TOGGLE : '[data-toggle="modal"]', | |||
| DATA_DISMISS : '[data-dismiss="modal"]', | |||
| FIXED_CONTENT : '.fixed-top, .fixed-bottom, .is-fixed, .sticky-top', | |||
| STICKY_CONTENT : '.sticky-top', | |||
There was a problem hiding this comment.
.sticky-top is in FIXED_CONTENT so I don't see the interest to add a new constant here 🤔
There was a problem hiding this comment.
Because sticky elements also need the padding which was and still is applied to all fixed elements, in addition to the new margin, to have the correct position. However, I could change the references to STICKY_CONTENT to the string .sticky-top if you want.
There was a problem hiding this comment.
No that's fine I just wanted to understand your thinking 👍
Johann-S
reviewed
Aug 25, 2017
js/src/modal.js
Outdated
| // Restore navbar-toggler margin | ||
| $(Selector.NAVBAR_TOGGLER).each((index, element) => { | ||
| // Restore sticky content and navbar-toggler margin | ||
| $(Selector.STICKY_CONTENT).add(Selector.NAVBAR_TOGGLER).each((index, element) => { |
There was a problem hiding this comment.
Maybe here you should do something like that :
$(`${Selector.STICKY_CONTENT} ${Selector.NAVBAR_TOGGLER}`)instead of .add
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23661