Fix some XSS in v3 #23687
Merged
Fix some XSS in v3 #23687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 26, 2017
js/carousel.js
Outdated
| @@ -208,8 +208,11 @@ | |||
| var clickHandler = function (e) { | |||
| var href | |||
| var $this = $(this) | |||
| var $target = $($this.attr('data-target') || (href = $this.attr('href')) && href.replace(/.*(?=#[^\s]+$)/, '')) // strip for ie7 | |||
| var target = $this.attr('data-target') || (href = $this.attr('href')) && href.replace(/.*(?=#[^\s]+$)/, '') // strip for ie7 | |||
|
Error in our |
|
Yeah, I don't think this branch is right. We have changes in v3-dev branch and that is what you should target. |
|
@mdo made a lot of work in this branch see : https://github.com/twbs/bootstrap/commits/v3.4.0-dev |
Johann-S
force-pushed
the
v3-xss-data-target
branch
from
3c3e598
to
603f925
Compare
houndci-bot
reviewed
Aug 26, 2017
js/carousel.js
Outdated
| @@ -208,8 +208,13 @@ | |||
| var clickHandler = function (e) { | |||
| var href | |||
| var $this = $(this) | |||
| var $target = $($this.attr('data-target') || (href = $this.attr('href')) && href.replace(/.*(?=#[^\s]+$)/, '')) // strip for ie7 | |||
| var target = $this.attr('data-target') | |||
| || (href = $this.attr('href')) && href.replace(/.*(?=#[^\s]+$)/, '') // strip for ie7 | |||
Johann-S
force-pushed
the
v3-xss-data-target
branch
from
603f925
to
d9be1da
Compare
|
But all I'm saying it's just when Mark is done, he should merge his changes in v3-dev. v3.4.0 seems a lot more specific, more of a WIP branch that will be merged to the base v3-dev one when done. |
XhmikosR
approved these changes
Sep 12, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20184 / CVE-2016-10735.