Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes color of popover arrow on bottom popovers #23762

Closed

Conversation

andresgalante
Copy link
Collaborator

There is a bug on popovers, the arrow on the bottom pop overs is white:

screen shot 2017-08-30 at 9 37 42 pm

I've changed it to header grey:
screen shot 2017-08-30 at 9 37 36 pm

What do you think?

@wojtask9
Copy link
Contributor

this is not right fix.
You assume that .popover always have .popover-header.

I had the same problem. My fix #23110

You also mentioned that you are working on rems in popover. Maybe my PR will help a little bit because right now in BS computations for .arrow assumes that border is always 1px width/height

@andresgalante
Copy link
Collaborator Author

@wojtask9 thanks for spotting that usecase, You are absolutely right. I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants