Switch to lowercase doctype.
#24217
Merged
Switch to lowercase doctype.
#24217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having it uppercase doesn't offer anything and the lowercase version improves slightly gzip compression.
XhmikosR
requested review from
mdo,
patrickhlauke,
bardiharborow,
Johann-S and
andresgalante
mdo
approved these changes
Oct 3, 2017
patrickhlauke
approved these changes
Oct 3, 2017
There was a problem hiding this comment.
I just double-checked, and yes it's valid (the doctype is case insensitive - see https://www.w3.org/TR/html51/syntax.html#the-doctype)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having it uppercase doesn't offer anything and the lowercase version slightly improves GZIP compression.
This was proposed a long time ago (can't find the issue/PR now) but we rejected it back then. Now I find no real gain in having an uppercase
doctypethus this PR.