Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropup in navbar for all the breakpoints #24244

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Fix dropup in navbar for all the breakpoints #24244

merged 1 commit into from
Oct 4, 2017

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Oct 4, 2017 •
edited
Loading

@Johann-S Johann-S mentioned this pull request Oct 4, 2017
Closed
wojtask9
wojtask9 reviewed Oct 4, 2017
View reviewed changes
Copy link
Contributor

@wojtask9 wojtask9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

scss/_navbar.scss Outdated
bottom: 100%;
}

.dropdown-toggle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary. .dropdown-toggle is already in _dropdown.scss. Nothing changes here.

scss/_navbar.scss Outdated

.dropup {
.dropdown-menu {
position: absolute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

position can be removed because it is already defined in line 157

bootstrap/scss/_navbar.scss

Line 157 in 579add5

position: absolute;

@Johann-S
Copy link
Member Author

Johann-S commented Oct 4, 2017

Thank you @wojtask9 for your code review 👍

@Johann-S Johann-S merged commit b9c4a5c into v4-dev Oct 4, 2017
@Johann-S Johann-S deleted the v4-dev-johann-dropup-navbar branch October 4, 2017 14:22
@mdo mdo mentioned this pull request Oct 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtask9 wojtask9 wojtask9 left review comments

@XhmikosR XhmikosR XhmikosR approved these changes

@mdo mdo Awaiting requested review from mdo

@andresgalante andresgalante Awaiting requested review from andresgalante

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Johann-S @XhmikosR @wojtask9