Adds animation to color on outlined btns #24465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
approved these changes
Oct 20, 2017
|
LGTM. Although the properties we animate are not the ones that are hardware accelerated, but I don't think it matters a lot here. Waiting for @mdo's approval. |
|
You are right, there is a repaint. |
|
Ideally, yeah, we should only animate the hardware accelerated properties everywhere. But it won't be an easy task. Maybe we should have an issue for this. |
mdo
approved these changes
Oct 22, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #24447 by adding an animation to
coloron outline buttons.