Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Util.jQuery which will detect jQuery instead of relying on global $ #24513

Merged
merged 2 commits into from
Oct 23, 2017
Merged

Add Util.jQuery which will detect jQuery instead of relying on global $ #24513

merged 2 commits into from
Oct 23, 2017

Conversation

Johann-S
Copy link
Member

Fixes #24500

@Johann-S Johann-S requested a review from XhmikosR October 23, 2017 07:01
XhmikosR
XhmikosR reviewed Oct 23, 2017
View reviewed changes
js/src/util.js Outdated
},

get jQuery() {
return window.$ || window.jQuery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change the order since jQuery should always be available?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 😉

@Johann-S Johann-S force-pushed the v4-dev-johann-jquery-detection branch from 9df7d45 to c4bd869 Compare October 23, 2017 07:23
XhmikosR
XhmikosR approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as tests pass.

@XhmikosR XhmikosR merged commit 1487c3a into v4-dev Oct 23, 2017
@XhmikosR XhmikosR deleted the v4-dev-johann-jquery-detection branch October 23, 2017 07:35
@mdo mdo mentioned this pull request Oct 23, 2017
Closed
@nextgenthemes nextgenthemes mentioned this pull request Oct 23, 2017
Closed
@bkdotcom bkdotcom mentioned this pull request Nov 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johann-S @XhmikosR