Adds margin variables for the hr element #24520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
requested changes
Oct 25, 2017
scss/_variables.scss
Outdated
| $mark-bg: #fcf8e3 !default; | ||
| $mark-bg: #fcf8e3 !default; | ||
|
|
||
| $hr-margin-top: 1rem !default; |
There was a problem hiding this comment.
Let's reassign this from $spacer and knock down to a single value to match our x/y approach elsewhere.
$hr-margin-y: $spacer !default;`
andresgalante
force-pushed
the
v4-dev-andres-adds-hr-variables
branch
from
e124787
to
c702800
Compare
Johann-S
approved these changes
Oct 26, 2017
mdo
approved these changes
Oct 28, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #24517 and adds
$hr-margin-topand$hr-margin-bottomfor the hr element.