Removes hardcoded colors references on variables.scss #24603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
changed the title
mdo
approved these changes
Oct 30, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #24600 and changes colors references on variables.scss from hardcoded to variables on the theme to keep consistency.
@mdo @XhmikosR there are 2 colors that are not on our color variables but can be closely achieved with darken and lightnen functions of
$redand$yellow:https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss#L285
https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss#L862
do you think it's worth it? or is it better to just leave them hardcoded?