Update babel to v7.0.0-beta.31 #24683

Johann-S · 2017-11-05T18:04:42Z

/CC @hzoo if you have time 😄

Johann-S · 2017-11-05T18:14:08Z

Hmm I didn't checked babel-eslint 😟

XhmikosR · 2017-11-05T19:22:28Z

Yup, that is the error I was getting when I tried to update too. EDIT: Ok I believe it's babel/babel-eslint#530

hzoo · 2017-11-06T00:57:56Z

package.json

@@ -80,12 +80,12 @@
    "popper.js": "^1.12.6"
  },
  "devDependencies": {
+    "@babel/cli": "7.0.0-beta.5",


can update to beta.31 now 😛 https://github.com/babel/babel/releases/tag/v7.0.0-beta.31

It's only 5 -> 31 because babylon was at 30

XhmikosR · 2017-11-06T00:58:56Z

.babelrc.js

@@ -1,11 +1,11 @@
 module.exports = {
  presets: [
    [
-      'env',
+      '@babel/env',


Is this really needed?

yep that's because the new babel namespace

yeah it's actually because we can't really know to default env to babel-preset-env or @babel/preset-env or @x/preset-env etc

hzoo

looks fine, just saying that you can change from beta.5 to beta.31 (it's supposed to be beta.6 but babylon was already at 30 and we moved it into the repo)

XhmikosR · 2017-11-06T01:00:26Z

@hzoo: we get build errors in babel-eslint; see the Travis build and my comment above.

XhmikosR · 2017-11-06T01:12:21Z

package.json

@@ -102,7 +102,7 @@
    "qunit-phantomjs-runner": "^2.3.0",
    "qunitjs": "^2.4.0",
    "rollup": "^0.50.0",
-    "rollup-plugin-babel": "^3.0.2",
+    "rollup-plugin-babel": "^4.0.0-beta.0",


Maybe we should remove ^ here.

hzoo · 2017-11-06T01:12:24Z

Ok that's unrelated to babel itself, I haven't looked at babel-eslint in a while actually but yeah maybe due to a newer version of eslint so it needs updates

XhmikosR · 2017-11-06T01:17:20Z

The thing is that we don't get any errors if we don't update to beta.5. Something is wrong somewhere :/

hzoo · 2017-11-06T01:29:24Z

Oh what, that really doesn't make sense then lol, since eslint is supposed to run on source code not the compiled code (right?), and they don't share dependencies either so that is really weird..🤔

Johann-S · 2017-11-06T08:32:01Z

I tried to update to the latest release of ESLint but we still have the same error 😟 https://travis-ci.org/twbs/bootstrap/jobs/297865624#L545

I removed external-helpers deps because rollup-plugin-babel in their new release handle that for us 👍

hzoo · 2017-11-06T19:20:47Z

aside: curious why the babelrc file is part of files in package.json? it shouldn't be on npm (it's not an issue since we renamed to .babelrc.js anyway but yea?

XhmikosR · 2017-11-06T19:27:25Z

@hzoo: exactly my point in #24582. It seems people were wrongfully pulling Bootstrap from npm and using our scripts, which is what I change in that PR.

hzoo · 2017-11-06T19:29:55Z

If you distribute a build on npm and someone tries to compile node_modules with Babel it will current read it and try to compile with that config which doesn't make sense unless they install your devDeps too (haven't quite figured out what the behavior should be though)

hzoo · 2017-11-06T19:34:13Z

Still have to investigate but I suppose it's an issue with npm trying to resolve different versions of the beta together? doesn't seem like there is any reason for it do be different because of a babel change

XhmikosR · 2017-11-06T19:34:32Z

I believe that previously we allowed this, but it doesn't make sense to me, thus why I changed it in that PR.

I expect when I pull a package from npm to either use it as is, or use my scripts for further processing.

hzoo · 2017-11-06T20:00:10Z

Ok lol so it must be a really weird dependency mismatch? I think 7.0.0-beta.0 is being matched by 7.0.0-beta.5 even though it's clearly a different version..

I just tested making the dependency scoped and it works.. https://github.com/babel/babel-eslint/blob/2004b913c7abef8d21cebca7f3ae39a9deaee767/package.json#L15

hzoo · 2017-11-06T20:01:01Z

try "babel-eslint": "^8.0.2", (worked for my locally after checking out this pr)

And update do beta.31 instead of beta.5?

XhmikosR · 2017-11-07T05:59:47Z

@hzoo: it seems babel-eslint 8.0.2 fixed the issue!

Now about beta.31, do we need to add babel/core manually?

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN bootstrap@4.0.0-beta.2 requires a peer of jquery@1.9.1 - 3 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/preset-env@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/cli@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN rollup-plugin-babel@4.0.0-beta.0 requires a peer of @babel/core@7 || ^7.0.0-beta but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-check-constants@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-proposal-async-generator-functions@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-proposal-optional-catch-binding@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-syntax-object-rest-spread@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-syntax-optional-catch-binding@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-syntax-async-generators@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-async-to-generator@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-proposal-object-rest-spread@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-proposal-unicode-property-regex@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-arrow-functions@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-block-scoped-functions@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-classes@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-computed-properties@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-destructuring@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-exponentiation-operator@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-duplicate-keys@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-block-scoping@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-for-of@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-function-name@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-literals@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-modules-amd@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-modules-commonjs@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-modules-umd@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-new-target@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-object-super@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-modules-systemjs@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-parameters@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-regenerator@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-spread@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-shorthand-properties@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-sticky-regex@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-template-literals@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-typeof-symbol@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @babel/plugin-transform-unicode-regex@7.0.0-beta.31 requires a peer of @babel/core@7.0.0-beta.31 but none is installed. You must install peer dependencies yourself.

XhmikosR · 2017-11-07T06:03:30Z

package.json

@@ -35,8 +35,8 @@
    "js-lint": "eslint js/ && eslint --config js/tests/.eslintrc.json --env node build/",
    "js-lint-docs": "eslint --config js/tests/.eslintrc.json assets/js/ docs/ sw.js",
    "js-compile": "npm-run-all --parallel js-compile-*",
-    "js-compile-standalone": "cross-env ROLLUP=true rollup --environment BUNDLE:false --config build/rollup.config.js --sourcemap",
-    "js-compile-bundle": "cross-env ROLLUP=true rollup --environment BUNDLE:true --config build/rollup.config.js --sourcemap",
+    "js-compile-standalone": "cross-env rollup --environment BUNDLE:false --config build/rollup.config.js --sourcemap",


Does this mean we can get rid of cross-env in these 2 lines?

Yep thanks to the removal of external-helpers

Can you remove it where it's no longer needed?

Nope we still use it one line under for js-compile-plugins instead of if we find a way to avoid the use of cross-env

Yes, but it seems it's redundant in these 2 lines here (not the plugins script

Yep I'll remove it

hzoo · 2017-11-07T13:10:08Z

Right @babel/core is a peerDep now so yes (so then you don't install v6 stuff)

XhmikosR · 2017-11-07T22:04:59Z

Thanks for all the help, I really appreciate it :)

…

On Nov 7, 2017 15:15, "Henry Zhu" ***@***.***> wrote: Right @babel/core is a peerDep now so yes (so then you don't install v6 stuff) — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#24683 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtUoHkBr-33S3av43LCvK6N7DZg1Jks5s0FfvgaJpZM4QSd_s> .

Johann-S requested a review from XhmikosR November 5, 2017 18:04

Johann-S added js v4 labels Nov 5, 2017

hzoo reviewed Nov 6, 2017

View reviewed changes

XhmikosR reviewed Nov 6, 2017

View reviewed changes

hzoo approved these changes Nov 6, 2017

View reviewed changes

XhmikosR reviewed Nov 6, 2017

View reviewed changes

Johann-S force-pushed the v4-dev-johann-update-babel branch from 1eaf615 to d116703 Compare November 6, 2017 08:28

XhmikosR reviewed Nov 7, 2017

View reviewed changes

XhmikosR force-pushed the v4-dev-johann-update-babel branch from 930e065 to ad2ebc1 Compare November 7, 2017 06:10

Update to babel beta 5

6c2e95b

Johann-S force-pushed the v4-dev-johann-update-babel branch from 7d9761e to 6c2e95b Compare November 7, 2017 13:31

XhmikosR changed the title ~~Update to babel beta 5~~ Update to babel to v7.0.0-beta.31 Nov 7, 2017

XhmikosR changed the title ~~Update to babel to v7.0.0-beta.31~~ Update babel to v7.0.0-beta.31 Nov 7, 2017

XhmikosR mentioned this pull request Nov 7, 2017

Update devDependencies. #24698

Closed

XhmikosR approved these changes Nov 7, 2017

View reviewed changes

Update devDependencies.

e06cf39

XhmikosR force-pushed the v4-dev-johann-update-babel branch from 3c12f23 to e06cf39 Compare November 7, 2017 17:51

XhmikosR merged commit 4bacf8d into v4-dev Nov 7, 2017

XhmikosR deleted the v4-dev-johann-update-babel branch November 7, 2017 23:04

mdo mentioned this pull request Nov 7, 2017

Beta 3 ship list #24439

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update babel to v7.0.0-beta.31 #24683

Update babel to v7.0.0-beta.31 #24683

Johann-S commented Nov 5, 2017

Johann-S commented Nov 5, 2017 •

edited

Loading

XhmikosR commented Nov 5, 2017 via email •

edited

Loading

hzoo Nov 6, 2017

XhmikosR Nov 6, 2017

Johann-S Nov 6, 2017

hzoo Nov 6, 2017

hzoo left a comment

XhmikosR commented Nov 6, 2017

XhmikosR Nov 6, 2017

hzoo commented Nov 6, 2017

XhmikosR commented Nov 6, 2017

hzoo commented Nov 6, 2017

Johann-S commented Nov 6, 2017 •

edited

Loading

hzoo commented Nov 6, 2017

XhmikosR commented Nov 6, 2017 •

edited

Loading

hzoo commented Nov 6, 2017

hzoo commented Nov 6, 2017

XhmikosR commented Nov 6, 2017

hzoo commented Nov 6, 2017

hzoo commented Nov 6, 2017 •

edited

Loading

XhmikosR commented Nov 7, 2017

XhmikosR Nov 7, 2017

Johann-S Nov 7, 2017

XhmikosR Nov 7, 2017

Johann-S Nov 7, 2017

XhmikosR Nov 7, 2017

Johann-S Nov 7, 2017

hzoo commented Nov 7, 2017

XhmikosR commented Nov 7, 2017 via email

Update babel to v7.0.0-beta.31 #24683

Update babel to v7.0.0-beta.31 #24683

Conversation

Johann-S commented Nov 5, 2017

Johann-S commented Nov 5, 2017 • edited Loading

XhmikosR commented Nov 5, 2017 via email • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzoo left a comment

Choose a reason for hiding this comment

XhmikosR commented Nov 6, 2017

Choose a reason for hiding this comment

hzoo commented Nov 6, 2017

XhmikosR commented Nov 6, 2017

hzoo commented Nov 6, 2017

Johann-S commented Nov 6, 2017 • edited Loading

hzoo commented Nov 6, 2017

XhmikosR commented Nov 6, 2017 • edited Loading

hzoo commented Nov 6, 2017

hzoo commented Nov 6, 2017

XhmikosR commented Nov 6, 2017

hzoo commented Nov 6, 2017

hzoo commented Nov 6, 2017 • edited Loading

XhmikosR commented Nov 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzoo commented Nov 7, 2017

XhmikosR commented Nov 7, 2017 via email

Johann-S commented Nov 5, 2017 •

edited

Loading

XhmikosR commented Nov 5, 2017 via email •

edited

Loading

Johann-S commented Nov 6, 2017 •

edited

Loading

XhmikosR commented Nov 6, 2017 •

edited

Loading

hzoo commented Nov 6, 2017 •

edited

Loading