Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explictly add cursor:pointer to dropdown menu items #25351

Closed
wants to merge 1 commit into from
Closed

Explictly add cursor:pointer to dropdown menu items #25351

wants to merge 1 commit into from

Conversation

patrickhlauke
Copy link
Member

Follow-up to #25082

Closes #25350

@XhmikosR
Copy link
Member

@patrickhlauke: Isn't there any way to inherit this?

@mdo
Copy link
Member

mdo commented Jan 18, 2018

Our v4 release is tomorrow morning, punting this to our next release.

@patrickhlauke
Copy link
Member Author

@patrickhlauke: Isn't there any way to inherit this?

inherit it from where? unless we add opinionated button { cursor: pointer; } or similar, i think explicitly defining it makes more sense. would also cover weirder scenarios where authors use some arbitrary element like <span role="button" tabindex="0"> or whatever in their menus

@XhmikosR
Copy link
Member

I thought we set this at a higher level, yeah. If not, your PR seems good to me. But the final decision is on @mdo :)

@MaPePeR
Copy link

MaPePeR commented Jan 23, 2018

The same problem exists with Buttons in List Groups (example from docs).

@mdo
Copy link
Member

mdo commented Feb 20, 2018

I think we'll go for #25598.

@mdo mdo closed this Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants