Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc update - remove media-breakpoint-up(xs) #26316

Merged
merged 6 commits into from
Apr 29, 2018
Merged

Doc update - remove media-breakpoint-up(xs) #26316

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d31f13c
Doc update - remove media-breakpoint-up(xs)
DavidDeSloovere Apr 16, 2018
510be3d
Improve media-breakpoint-up/down docs
DavidDeSloovere Apr 18, 2018
2242a74
Merge branch 'v4-dev' into patch-1
DavidDeSloovere Apr 20, 2018
687506e
Fix indenting
DavidDeSloovere Apr 23, 2018
f3a48b0
Merge branch 'v4-dev' into patch-1
DavidDeSloovere Apr 23, 2018
3eae0cb
correct some docs text
mdo Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions docs/4.1/layout/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Bootstrap primarily uses the following media query ranges—or breakpoints—in

{% highlight scss %}
// Extra small devices (portrait phones, less than 576px)
// No media query since this is the default in Bootstrap
// No media query for `xs` since this is the default in Bootstrap

// Small devices (landscape phones, 576px and up)
@media (min-width: 576px) { ... }
Expand All @@ -70,15 +70,18 @@ Bootstrap primarily uses the following media query ranges—or breakpoints—in
Since we write our source CSS in Sass, all our media queries are available via Sass mixins:

{% highlight scss %}
@include media-breakpoint-up(xs) { ... }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's actually swap this with something that explicitly states there's no xs query?

// No media query necessary for `xs` breakpoint as it's effectively `@media (min-width: 0) { ... }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. People might think 'where is xs'.

// No media query necessary for xs breakpoint as it's effectively `@media (min-width: 0) { ... }`
@include media-breakpoint-up(sm) { ... }
@include media-breakpoint-up(md) { ... }
@include media-breakpoint-up(lg) { ... }
@include media-breakpoint-up(xl) { ... }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's insert an example then to back up that xs comment I suggested earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added example, hope I interpreted the comment correctly.

// Example usage:
// Example: Hide starting at `min-width: 0`, and then show at the `sm` breakpoint
.custom-class {
display: none;
}
@include media-breakpoint-up(sm) {
.some-class {
.custom-class {
display: block;
}
}
Expand Down Expand Up @@ -112,6 +115,14 @@ Once again, these media queries are also available via Sass mixins:
@include media-breakpoint-down(sm) { ... }
@include media-breakpoint-down(md) { ... }
@include media-breakpoint-down(lg) { ... }
// No media query necessary for xl breakpoint as it has no upper bound on its width

// Example: Style from medium breakpoint and down
@include media-breakpoint-down(md) {
.custom-class {
display: block;
}
}
{% endhighlight %}

There are also media queries and mixins for targeting a single segment of screen sizes using the minimum and maximum breakpoint widths.
Expand Down