add originalEvent to _clearMenus function #26343
Conversation
There was a problem hiding this comment.
Please fix this error: https://travis-ci.org/twbs/bootstrap/jobs/368542629#L1156
and you must add a unit test to cover this case
|
@Johann-S error was fixed |
|
Please add a unit test |
js/src/dropdown.js
Outdated
| @@ -341,6 +341,10 @@ const Dropdown = (($) => { | |||
| relatedTarget: toggles[i] | |||
| } | |||
|
|
|||
| if (event) { | |||
| relatedTarget.original = event.originalEvent | |||
There was a problem hiding this comment.
relatedTarget.originalEvent would be better
XhmikosR
changed the title
|
Why did you limit this event to click ? |
|
@Johann-S I wanted to avoid a collision with the name |
js/src/dropdown.js
Outdated
| @@ -341,6 +341,10 @@ const Dropdown = (($) => { | |||
| relatedTarget: toggles[i] | |||
| } | |||
|
|
|||
| if (event && event.type === 'click') { | |||
| relatedTarget.mouseEvent = event | |||
js/tests/unit/dropdown.js
Outdated
| @@ -498,6 +498,39 @@ $(function () { | |||
| $dropdown.trigger('click') | |||
| }) | |||
|
|
|||
| QUnit.test('should fire hide and hidden event with a mouseEvent', function (assert) { | |||
There was a problem hiding this comment.
I you want to add this property only for click event, you should add a test which verify this property isn't added on other type of events
js/tests/unit/dropdown.js
Outdated
| assert.notOk(e.clickEvent) | ||
| }) | ||
| .on('hidden.bs.dropdown', function (e) { | ||
| assert.onotO(e.clickEvent) |
There was a problem hiding this comment.
assert.onotO(e.clickEvent) I don't think onotO exist on assert 😆
|
@Johann-S: does this need to be documented in docs? |
|
yep that can be usefull, good catch @XhmikosR 👍 |
|
Closing for lack of replies. |
|
Hi @XhmikosR , why did you close this pull request? Is there any action that I have to do? Or somebody else? |
fixes #26336