Form control heights #26820
Merged
Form control heights #26820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
force-pushed
the
input-height
branch
2 times, most recently
from
7d0931b to
c7a5d43
Compare
|
There should be also textarea height auto when rows attribute is applied. |
- Use the already present -height variables on .form-control - Consolidate the select size and multiple overrides into the .form-control base class instead of sm/lg modifiers - Remove the Sass extends from input groups since it picks up too many selectors
Closed
|
I think this might need to be reopened? After the fix now the Comparism of v4.0 and the current v4.1, when you set
|
|
You can add h-auto to form-control. |
|
@danijelGombac Thanks, I did figure the workaround but the thing is still broken now in comparison to v4.0, because |
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Nov 9, 2018
In latest Twitter Bootstrap versions form-control height is no more auto and this change is needed to make our search bar work properly, see: twbs/bootstrap#26820
jmdfm
pushed a commit
to kiso-io/rrt-gem
that referenced
this pull request
May 11, 2019
|
1px padding on Windows, latest Chrome with height property on v4.4.1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow I missed that #18842 and #18843 were still open. In my testing of the macOS Mojave beta, Safari has fixed their issue with the sizing, but Chrome still has the issue. It also apparently is a bug marked as won't fix. Thus, the only sensible solution to consistent
.form-controlheights across all supported inputtypes in a single browser is to specifyheights. I've been resisting this thinking it'd be resolved by browsers, but that's no longer the case.Here's what's changed:
$input-heightto.form-control.<select>sizeandmultipleoverrides into just the.form-controlbase class instead of-sm/-lgmodifiers.@extends from input groups since it picks up too many selectors, namely our<select>overrides.Seen this demo of the changed CSS and inputs/selects.
Related test JS Bin example.
Closes #18843, fixes #18842, fixes #25923, fixes #26648, and fixes #26209.