Input group scss refactoring #28309
Closed
Input group scss refactoring #28309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
previously requested changes
Feb 19, 2019
|
And make sure tests pass ofc. |
ysds
suggested changes
Feb 19, 2019
Co-Authored-By: alexandreDavid <alexandre.David42@gmail.com>
vsn4ik
reviewed
Feb 21, 2019
| line-height: $input-line-height-sm; | ||
| @include border-radius($input-border-radius-sm); | ||
| .input-group-sm { | ||
| @include input-group-size($input-height-sm, $input-padding-y-sm, $input-padding-x-sm, $input-font-size-sm, $input-line-height-sm, $input-border-radius-sm); | ||
| } | ||
|
|
||
| .input-group-lg > .custom-select, |
There was a problem hiding this comment.
Maybe:
.input-group-lg > .custom-select,
.input-group-sm > .custom-select {
padding-right: $custom-select-padding-x + $custom-select-indicator-padding;
}
->
@mixin input-group-size(...) {
...
> .custom-select {
padding-right: $custom-select-padding-x + $custom-select-indicator-padding;
}
}
?
|
@MartijnCuppens We already have a file for similar sizing mixin - mixin/_pagination.scss. Maybe we should choose to add the input group sizing mixin or remove the pagination' one for consistency. |
|
Closing this to consolidate #29885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a mixin for removing duplicated code.