-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pa11y-ci for automated accessibility tests #29315
Conversation
fd1a9dc
to
6910e98
Compare
6910e98
to
f0ee28b
Compare
f0ee28b
to
0a86a43
Compare
0a86a43
to
3fd5aed
Compare
4401abe
to
601ead7
Compare
I've made some progress with this a few days ago. I added the HTML results to CI so one can download them and review them. The pa11-ci tests run only on Node.js 12 so you need to visit this action to get the results. AFAICT we need to ignore some selectors that we know that will fail color contrast (and maybe all of the examples?), and we can try fixing the remaining issues. Any help is welcome. :) |
f49f19f
to
cb81dc5
Compare
FWIW, pa11y has a Also while working on this, I temporarily disabled contrast checking since there were too many failures (more than 15.000!) by using: "ignore": [
"WCAG2AA.Principle1.Guideline1_4.1_4_3.G18"
] Result is much more readable :) Still working on it but I might have more to share soon! |
aa0a889
to
a406a32
Compare
a406a32
to
2bbf187
Compare
a02bb10
to
8353840
Compare
9460fe1
to
f782eaa
Compare
f782eaa
to
4ccbfbd
Compare
4ccbfbd
to
ee1562b
Compare
Is this PR still worth pursuing at this point, or do we need a fresh take on it? |
There's no need for a fresh take in it, I can rebase it. We need to solve the TODO I have in the OP. |
847cc41
to
9ca7cfb
Compare
5b59011
to
9585e8f
Compare
Add pa11y-ci-reporter-html and also upload the HTML results to CI if there are failures
00b5da3
to
c7f1862
Compare
This is mostly a POC and it will need a lot more tweaking and some of my other PRs finished first, like #29208.
hideElements
(*-success
, etc)("hideElements": "[class*=-success], [class*=-info]"
)html
reporter (https://github.com/pa11y/pa11y-reporter-html)