config.yml: update popper.js to v1.16.0 #29624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnCuppens
approved these changes
Nov 2, 2019
|
If this changes soon (like in the next 2-3 days) we might not need to switch CDNs. I'm gonna wait a few days. I just want this in before we release v4.4.0. |
|
I think I'm going to merge this since I don't see it fixed upstream. And we should probably revisit the other cdnjs links later, if this isn't resolved soon. |
XhmikosR
added a commit
that referenced
this pull request
Nov 12, 2019
XhmikosR
added a commit
that referenced
this pull request
Nov 25, 2019
|
Note that the only officially supported Popper CDN is unpkg.com, I don't have any way to control other CDNs. |
|
NP jsdelivr is automatically updated anyway
…On Sat, Nov 30, 2019, 12:26 Federico Zivolo ***@***.***> wrote:
Note that the only officially supported Popper CDN is unpkg.com, I don't
have any way to control other CDNs.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#29624?email_source=notifications&email_token=AACVLNI7ZJQNK7HXWRG7ICTQWI5XBA5CNFSM4JID3SL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQA4DQ#issuecomment-559943182>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNI3G7WMMXG2SVMG3LLQWI5XBANCNFSM4JID3SLQ>
.
|
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems cdnjs has some issues and doesn't have popper.js 1.16.0. I switched to jsdelivr so that we are consistent with the version we use.