-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config.yml: update popper.js to v1.16.0 #29624
Conversation
If this changes soon (like in the next 2-3 days) we might not need to switch CDNs. I'm gonna wait a few days. I just want this in before we release v4.4.0. |
I think I'm going to merge this since I don't see it fixed upstream. And we should probably revisit the other cdnjs links later, if this isn't resolved soon. |
Note that the only officially supported Popper CDN is unpkg.com, I don't have any way to control other CDNs. |
NP jsdelivr is automatically updated anyway
…On Sat, Nov 30, 2019, 12:26 Federico Zivolo ***@***.***> wrote:
Note that the only officially supported Popper CDN is unpkg.com, I don't
have any way to control other CDNs.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#29624?email_source=notifications&email_token=AACVLNI7ZJQNK7HXWRG7ICTQWI5XBA5CNFSM4JID3SL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQA4DQ#issuecomment-559943182>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNI3G7WMMXG2SVMG3LLQWI5XBANCNFSM4JID3SLQ>
.
|
It seems cdnjs has some issues and doesn't have popper.js 1.16.0. I switched to jsdelivr so that we are consistent with the version we use.