V4 dev backports #30592
Merged
V4 dev backports #30592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 04b8219.
Cleans up some column classes to ensure things line up across all viewports. Also fixes some broken padding on the .navbar-brand. Co-authored-by: XhmikosR <xhmikosr@gmail.com>
XhmikosR
force-pushed
the
v4-dev-xmr
branch
2 times, most recently
from
2947ea0 to
e13db00
Compare
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
XhmikosR
force-pushed
the
v4-dev-xmr
branch
2 times, most recently
from
cb15aaa to
e351318
Compare
XhmikosR
force-pushed
the
v4-dev-xmr
branch
2 times, most recently
from
9692fb8 to
f9bd7d7
Compare
Johann-S
approved these changes
Apr 28, 2020
|
@MartijnCuppens can you confirm the dashboard and the a11y changes are OK and if so approve? |
MartijnCuppens
force-pushed
the
v4-dev-xmr
branch
from
7c0a032 to
bb4375f
Compare
|
Spotted 1 missing color change ( |
|
Ow, ok, shouldn't we just ditch the # than? Edit: I removed the # and pushed the change |
This is so that bundlewatch compares against v4-dev and not master.
The latest `actions/setup-node` prints this info by default
MartijnCuppens
force-pushed
the
v4-dev-xmr
branch
from
bb4375f to
77a0e96
Compare
|
It was referring to the commit hash, not sure why it wasn't highlighted.
I'll check it out later.
…On Tue, Apr 28, 2020, 20:02 Martijn Cuppens ***@***.***> wrote:
Ow, ok, shouldn't we just ditch the # than?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30592 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNMFJH66FQP6RUQTX7LRO4D4HANCNFSM4MISBZGQ>
.
|
It wasn't highlighted because it was prefixed with |
Duh! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-30592--twbs-bootstrap.netlify.com/
TODO: