Drop Legacy Edge support. #31972

XhmikosR · 2020-10-26T14:58:50Z

Needs thorough review in case something is wrong, for example some of the vendor prefixes.

~~Also, it seems we can drop more code like the Polyfills, but I need some help with that.~~

Preview: https://deploy-preview-31972--twbs-bootstrap.netlify.app/

Closes #32017 along the way

XhmikosR · 2020-10-29T17:30:10Z

Split from #30986. I think we are going to leave any further JS code cleanup for later.

@twbs/css-review please make sure I didn't remove something that's still needed 🙂

mdo

Looks great for CSS! Stoked to drop so much for even the form range component. Crazy how much those pseudo elements add.

js/tests/visual/tooltip.html

XhmikosR · 2020-10-29T18:03:55Z

site/content/docs/5.0/migration.md

@@ -9,6 +9,10 @@ toc: true

 ## v5.0.0-alpha3

+### Browser support
+
+- Dropped support for Microsoft Legacy Edge. See [here](#browser-support-1) for the previous browser support changes.


Not sure if there is any other way to do this so that it's foolproof; now it's fragile and will break if we add another Browser support heading.

Another naming nit-pick. 'Microsoft Legacy Edge' should be 'Microsoft Edge Legacy'. (that's Microsoft's official name)
REF: https://support.microsoft.com/en-us/microsoft-edge/what-is-microsoft-edge-legacy-3e779e55-4c55-08e6-ecc8-2333768c0fb0
https://support.microsoft.com/en-us/microsoft-edge/what-s-the-difference-between-the-new-microsoft-edge-and-microsoft-edge-legacy-a01258e5-8c05-7bbb-bed2-c65bec0eb126

MartijnCuppens · 2020-10-29T18:11:39Z

Still spotted some Edge references in the md files (browsers-devices.md for example). CSS wise it looks ok.

XhmikosR · 2020-10-29T18:28:47Z

I intentionally kept those, should I remove them?

…

On Thu, Oct 29, 2020, 20:11 Martijn Cuppens ***@***.***> wrote: Still spotted some Edge references in the md files (browsers-devices.md for example). CSS wise it looks ok. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31972 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNI7UI7O4NAKWRFUG5TSNGV65ANCNFSM4S7PZJVQ> .

MartijnCuppens · 2020-10-29T18:42:28Z

Yeah, this seems to be incorrect now:

bootstrap/site/content/docs/5.0/getting-started/browsers-devices.md

Line 11 in d2c13e0

    
           Bootstrap supports the **latest, stable releases** of all major browsers and platforms. This also includes the latest version of Legacy Edge (EdgeHTML layout engine).

Just spotted this could also be removed:

bootstrap/scss/forms/_floating-labels.scss

Lines 66 to 85 in d2c13e0

    
           // 
        
           // Fallback for classic Edge 
        
           // 
        
           @supports (-ms-ime-align: auto) { 
        
             .form-floating { 
        
               display: flex; 
        
               flex-direction: column-reverse; 
        
             } 
        
             .form-floating > label { 
        
               position: static; 
        
               padding: 0; 
        
               margin-bottom: calc(#{$form-floating-padding-y} / 2); // stylelint-disable-line function-disallowed-list 
        
               border: 0; 
        
               @include transition(none); 
        
             } 
        
             .form-floating > .form-control::-ms-input-placeholder { 
        
               color: $input-placeholder-color; 
        
             } 
        
           }

XhmikosR · 2020-10-29T18:51:38Z

All right, I'll update the docs tomorrow too.

…

On Thu, Oct 29, 2020, 20:42 Martijn Cuppens ***@***.***> wrote: Yeah, this seems to be incorrect now: https://github.com/twbs/bootstrap/blob/d2c13e0f3187ed00f62fb3905cc34b1ffd7d3010/site/content/docs/5.0/getting-started/browsers-devices.md#L11 Just spotted this could also be removed: https://github.com/twbs/bootstrap/blob/d2c13e0f3187ed00f62fb3905cc34b1ffd7d3010/scss/forms/_floating-labels.scss#L66-L85 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31972 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNNI5GLCQZVF3V42NDTSNGZSNANCNFSM4S7PZJVQ> .

XhmikosR · 2020-10-30T07:28:50Z

PR updated. The only thing I'm not sure about is this:

This approach works in the new Microsoft Edge built on Chromium and gracefully degrades on older versions.

ffoodd · 2020-10-30T13:51:35Z

Sidenote here about our philosophy: shouldn't we use progressive enhancement as a basis, to ensure nothing's broken on unsupported browsers? I'm thinking of our new floating labels—as far as I remember they were barely unusable no Edge before I added a few things— but there might be more cases.

Could be as easy as wrapping our code in @supports() rules.

mdo · 2020-10-30T20:26:30Z

Good question @ffoodd. I think our approach needs to be more about embracing the future, and less about making the old stuff work. At least with our major version releases. If folks need to support older browsers, they should continue using v4. We should codify that maybe in these docs and update that snippet that @XhmikosR highlighted.

XhmikosR · 2020-11-03T13:47:38Z

I think this is ready for a final review. I made #32057 for the polyfills, but I could also move that change here.

I assume we all stick with the decision to drop Legacy Edge support, right?

Unfortunately, there's no sweet spot between size/redundant code and progressive enhancement AFAICT; we either keep some dead code or forget about progressive enhancement.

Johann-S

LGTM 👍 happy to see those polyfills gone

XhmikosR · 2020-11-04T08:39:17Z

Merged the polyfills removal to this PR so that we have everything in one place.

I think the only thing left is this: #31972 (comment)

PR updated. The only thing I'm not sure about is this:

This approach works in the new Microsoft Edge built on Chromium and gracefully degrades on older versions.

mdo · 2020-11-04T19:50:32Z

This approach works in the new Microsoft Edge built on Chromium and gracefully degrades on older versions.

I'd say remove that sentence entirely @XhmikosR.

coliff · 2020-11-04T05:59:55Z

.browserslistrc

@@ -5,7 +5,9 @@ last 1 major version
 not dead
 Chrome >= 60
 Firefox >= 60
-Edge >= 16
+# needed since Edge still has usage;


I think this should probably say 'needed since Edge Legacy still has usage;'

coliff · 2020-11-04T06:02:47Z

.browserslistrc

@@ -5,7 +5,9 @@ last 1 major version
 not dead
 Chrome >= 60
 Firefox >= 60
-Edge >= 16
+# needed since Edge still has usage;
+# 79 was the first Edgium version


'Edgium' was a nickname and not an official term. I suggest it says 'Chromium' or 'Blink' instead.

coliff · 2020-11-04T06:05:36Z

site/content/docs/5.0/migration.md

@@ -9,6 +9,10 @@ toc: true

 ## v5.0.0-alpha3

+### Browser support
+
+- Dropped support for Microsoft Legacy Edge. See [here](#browser-support-1) for the previous browser support changes.


Another naming nit-pick. 'Microsoft Legacy Edge' should be 'Microsoft Edge Legacy'. (that's Microsoft's official name)
REF: https://support.microsoft.com/en-us/microsoft-edge/what-is-microsoft-edge-legacy-3e779e55-4c55-08e6-ecc8-2333768c0fb0
https://support.microsoft.com/en-us/microsoft-edge/what-s-the-difference-between-the-new-microsoft-edge-and-microsoft-edge-legacy-a01258e5-8c05-7bbb-bed2-c65bec0eb126

This allows us to move forward without being held back. Microsoft already replaces the Legacy Edge with the new one on supported Windows versions.

XhmikosR force-pushed the main-xmr-drop-edge branch from 1648731 to 68fb51a Compare October 29, 2020 17:28

XhmikosR marked this pull request as ready for review October 29, 2020 17:28

XhmikosR requested review from a team as code owners October 29, 2020 17:28

XhmikosR added the v5 label Oct 29, 2020

XhmikosR force-pushed the main-xmr-drop-edge branch from 68fb51a to 671541f Compare October 29, 2020 17:32

mdo approved these changes Oct 29, 2020

View reviewed changes

XhmikosR commented Oct 29, 2020

View reviewed changes

js/tests/visual/tooltip.html Outdated Show resolved Hide resolved

XhmikosR force-pushed the main-xmr-drop-edge branch from 671541f to d2c13e0 Compare October 29, 2020 18:00

XhmikosR commented Oct 29, 2020

View reviewed changes

XhmikosR force-pushed the main-xmr-drop-edge branch from d2c13e0 to c6c736a Compare October 30, 2020 07:28

XhmikosR force-pushed the main-xmr-drop-edge branch from c6c736a to c4177c0 Compare November 3, 2020 13:22

XhmikosR mentioned this pull request Nov 3, 2020

Remove the now redundant polyfills. #32057

Merged

XhmikosR requested review from mdo, MartijnCuppens, ffoodd, Johann-S and patrickhlauke November 3, 2020 13:45

XhmikosR added the breaking-change label Nov 3, 2020

MartijnCuppens approved these changes Nov 3, 2020

View reviewed changes

Johann-S approved these changes Nov 3, 2020

View reviewed changes

XhmikosR force-pushed the main-xmr-drop-edge branch from 08a94ba to 047bfca Compare November 4, 2020 08:35

XhmikosR force-pushed the main-xmr-drop-edge branch from 047bfca to eb06ad1 Compare November 5, 2020 06:24

coliff reviewed Nov 5, 2020

View reviewed changes

XhmikosR added 3 commits November 5, 2020 08:37

Drop Legacy Edge support.

579ccc3

This allows us to move forward without being held back. Microsoft already replaces the Legacy Edge with the new one on supported Windows versions.

Remove the now unneeded polyfills.

7c6c5e6

Tighten bundlewatch limits.

df7df9a

XhmikosR force-pushed the main-xmr-drop-edge branch from 4130ee6 to df7df9a Compare November 5, 2020 06:38

rohit2sharma95 approved these changes Nov 5, 2020

View reviewed changes

XhmikosR merged commit f989f8f into main Nov 5, 2020

XhmikosR deleted the main-xmr-drop-edge branch November 5, 2020 13:37

maxokorokov mentioned this pull request Nov 12, 2020

Bootstrap 5 support ng-bootstrap/ng-bootstrap#3899

Closed

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop Legacy Edge support. #31972

Drop Legacy Edge support. #31972

XhmikosR commented Oct 26, 2020 •

edited

Loading

XhmikosR commented Oct 29, 2020

mdo left a comment

XhmikosR Oct 29, 2020

coliff Nov 4, 2020

MartijnCuppens commented Oct 29, 2020

XhmikosR commented Oct 29, 2020 via email

MartijnCuppens commented Oct 29, 2020

XhmikosR commented Oct 29, 2020 via email

XhmikosR commented Oct 30, 2020

ffoodd commented Oct 30, 2020

mdo commented Oct 30, 2020

XhmikosR commented Nov 3, 2020

Johann-S left a comment

XhmikosR commented Nov 4, 2020 •

edited

Loading

mdo commented Nov 4, 2020

coliff Nov 4, 2020

coliff Nov 4, 2020

coliff Nov 4, 2020

Drop Legacy Edge support. #31972

Drop Legacy Edge support. #31972

Conversation

XhmikosR commented Oct 26, 2020 • edited Loading

XhmikosR commented Oct 29, 2020

mdo left a comment

Choose a reason for hiding this comment

XhmikosR Oct 29, 2020

Choose a reason for hiding this comment

coliff Nov 4, 2020

Choose a reason for hiding this comment

MartijnCuppens commented Oct 29, 2020

XhmikosR commented Oct 29, 2020 via email

MartijnCuppens commented Oct 29, 2020

XhmikosR commented Oct 29, 2020 via email

XhmikosR commented Oct 30, 2020

ffoodd commented Oct 30, 2020

mdo commented Oct 30, 2020

XhmikosR commented Nov 3, 2020

Johann-S left a comment

Choose a reason for hiding this comment

XhmikosR commented Nov 4, 2020 • edited Loading

mdo commented Nov 4, 2020

coliff Nov 4, 2020

Choose a reason for hiding this comment

coliff Nov 4, 2020

Choose a reason for hiding this comment

coliff Nov 4, 2020

Choose a reason for hiding this comment

XhmikosR commented Oct 26, 2020 •

edited

Loading

XhmikosR commented Nov 4, 2020 •

edited

Loading