Add equal column mixin #32155
Merged
Add equal column mixin #32155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfxd
force-pushed
the
equal-column-mixin
branch
from
a7dbc6b
to
78a68ae
Compare
|
I think I can dig this. Put together a little Codepen: https://codepen.io/emdeoh/pen/JjRbXYr. Since this only changes the mixin, I don't see any problems for us. Wondering if we need to update any docs? |
|
Do you need me to make edits to that codepen? It looks like what I have in mind. I can add a quick note for the docs about the default behavior. |
|
No codepen edits needed. Just some docs updates I think to mention the behavior. Not sure where myself just yet, so feel free to suggest! |
cfxd
force-pushed
the
equal-column-mixin
branch
from
9aa086c
to
0fe5300
Compare
Make equal cols the default Add documentation
cfxd
force-pushed
the
equal-column-mixin
branch
from
0fe5300
to
cdf4606
Compare
|
Ok, thank you! Added a docs edit and rebased 👍🏻 |
mdo
approved these changes
Apr 5, 2021
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add equal column mixin so that we can do@include make-col-eqinstead of having to extend the.colclass or use it in markup.Make the
make-colmixin default to equal columns when not providing a column size.