Decouple BackDrop from modal #32439
Merged
Decouple BackDrop from modal #32439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
from
f18847d
to
9e5bca6
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
2 times, most recently
from
bfd37c9
to
3bdbe43
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
from
459fd7a
to
9ebb987
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
from
83c261e
to
af28030
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
5 times, most recently
from
8f5868c
to
e7236ea
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
3 times, most recently
from
3bd76c0
to
8c3479a
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
from
8c3479a
to
13ab497
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
2 times, most recently
from
50355b9
to
cf96fc3
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
2 times, most recently
from
6a38496
to
803d62c
Compare
rohit2sharma95
force-pushed
the
baackdrop-as-separate-module
branch
from
803d62c
to
86c66a3
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
from
a89a9cd
to
c503659
Compare
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
from
c503659
to
09eb84c
Compare
alpadev
approved these changes
Apr 8, 2021
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
from
09eb84c
to
05ca443
Compare
rohit2sharma95
approved these changes
Apr 14, 2021
remove PromiseTimout usage revert class name
GeoSot
force-pushed
the
baackdrop-as-separate-module
branch
from
522dfef
to
2e0b0a7
Compare
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a comment was post on offcanvas merge request, I did a first approach to decouple Backdrop from Modal, for further usage and to simplify Modal code.
It misses the extra tests and a class modification, but they can be done, if you like it
Preview: https://deploy-preview-32439--twbs-bootstrap.netlify.app/docs/5.0/components/modal/
TODO: