Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal: move common code to a new isAnimated method #33056

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Feb 11, 2021

No description provided.

@GeoSot GeoSot requested a review from a team as a code owner February 11, 2021 21:54
@GeoSot GeoSot changed the title Add 'isAnimated' method on Modal Add 'isAnimated' property on Modal Feb 11, 2021
@mdo
Copy link
Member

mdo commented Feb 12, 2021

Does this fix a particular issue or is it in support of something else?

@mdo mdo added the js label Feb 12, 2021
@GeoSot
Copy link
Member Author

GeoSot commented Feb 12, 2021

Not Something special. Tiding up same checks, that are written in different ways

js/src/modal.js Outdated Show resolved Hide resolved
@GeoSot GeoSot force-pushed the add-is-animated-method-on-modal branch from f15d58c to 3005b9d Compare March 5, 2021 21:09
@GeoSot GeoSot changed the title Add 'isAnimated' property on Modal Add 'isAnimated' method on Modal Mar 5, 2021
@GeoSot GeoSot force-pushed the add-is-animated-method-on-modal branch from 3005b9d to 1261575 Compare March 5, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants