Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust SAFE_URL_PATTERN regex for use with test method of regexes. #33136

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Adjust SAFE_URL_PATTERN regex for use with test method of regexes. #33136

merged 3 commits into from
Feb 19, 2021

Commits on Feb 17, 2021

  1. Adjust regex SAFE_URL_PATTERN for use with test method. 

    The test method on regexes behaves different than the match method on strings in the presence of the global modifier.
See here for an example where the same input returns true, then false:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/test
Adds escapes for slashes and a unit test for sanitizing the same template twice.
    @nikonthethird
    nikonthethird committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    1214a74 View commit details
    Browse the repository at this point in the history

  2. Make the linter happy.

    @nikonthethird
    nikonthethird committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    313fbf4 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Merge branch 'main' into fix-33124

    @XhmikosR
    XhmikosR authored Feb 19, 2021
    Configuration menu
    Copy the full SHA
    2cf0b73 View commit details
    Browse the repository at this point in the history