Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of the Offcanvas constructor #33261

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

rohit2sharma95
Copy link
Collaborator

@rohit2sharma95 rohit2sharma95 commented Mar 4, 2021

It is not Offcanvas, it is OffCanvas.

I am not sure if it should be changed from OffCanvas to Offcanvas in the js files. Since @mdo said in the comment, I'm leaving everything as offcanvas, from source code to usage in the docs.

@mdo
Copy link
Member

mdo commented Mar 11, 2021

Everything should be offcanvas/Offcanvas, no hypens or other casing.

@rohit2sharma95 rohit2sharma95 requested a review from a team as a code owner March 16, 2021 04:43
@rohit2sharma95 rohit2sharma95 changed the title Change the name of the constructor in offcanvas's documentation Change the name of the Offcanvas constructor Mar 16, 2021
@rohit2sharma95 rohit2sharma95 added js and removed docs labels Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants