Update modal's show method to accept relatedTarget as an argument
#33300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What exactly are you trying to improve here? |
|
@XhmikosR explore missed parameter |
|
@rohit2sharma95 please check this out if it's right or now (and feel free to rename the PR title/variables etc ) |
rohit2sharma95
changed the title
bootstrap.Modal.show(relatedTarget)relatedTarget as an argument
| @@ -892,6 +892,13 @@ Manually opens a modal. **Returns to the caller before the modal has actually be | |||
| myModal.show() | |||
| ``` | |||
|
|
|||
| Also, you can pass related target: | |||
There was a problem hiding this comment.
Also, please mention that the DOM element passed as the first argument can be received in the modal events (as the relatedTarget property)
rohit2sharma95
changed the title
relatedTarget as an argumentshow method to accept relatedTarget as an argument
rohit2sharma95
approved these changes
Mar 14, 2021
GeoSot
approved these changes
Mar 15, 2021
This was referenced Jul 12, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new example for
bootstrap.Modal.show(relatedTarget)