Fix v5 regressions in tab dropdown functionality #33626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #33625 (fixes the 1st problem, at least)
I'd also be happy to help address the 2nd issue, but I'm not sure whether you'd prefer to just update the docs, or actually fix the
Tab
logic to support.dropdown-item
s wrapped in<li>
To do the latter, looks as though we need to modify the 1st part of this logic to do something closer to
const dropdownElement = element.parents(SELECTOR_DROPDOWN).find(CLASS_NAME_DROPDOWN_MENU)
bootstrap/js/src/tab.js
Lines 165 to 174 in db32b23