Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for scrollbar.js & better handling if a style property doesn't exist #33948

Merged
merged 2 commits into from
May 20, 2021
Merged

Add tests for scrollbar.js & better handling if a style property doesn't exist #33948

merged 2 commits into from
May 20, 2021

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented May 12, 2021 •
edited
Loading

  • Add some tests on scrollbar.js
  • Sanitize the old ones
  • Transfer tests from modal.spec. to scrollbar.spec
  • Add check, on _setElementAttributes not to set data-attribute if it doesn't exists

@GeoSot GeoSot marked this pull request as ready for review May 12, 2021 00:31
@GeoSot GeoSot requested a review from a team as a code owner May 12, 2021 00:31
@GeoSot GeoSot force-pushed the gs-scrollbar-fixes branch 2 times, most recently from 6d8501d to bc4d834 Compare May 13, 2021 20:43
@GeoSot GeoSot requested a review from alpadev May 18, 2021 22:12
alpadev
alpadev approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@alpadev alpadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GeoSot
scrollbar.js:
e10c143 
add some tests
transfer test from modal.spec. to scrollbar.spec
proper handling if style property doesn't exist
@GeoSot
fixes after review
5ad77f7
@GeoSot GeoSot merged commit 79c3bf4 into main May 20, 2021
@GeoSot GeoSot deleted the gs-scrollbar-fixes branch May 20, 2021 13:29
@GeoSot GeoSot mentioned this pull request May 20, 2021
Merged
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request May 20, 2021
@GeoSot @marvin-hinkley
Add Tests on scrollbar.js & better handling if a style property doesn…
f955e4b 
…'t exists (twbs#33948)

* scrollbar.js:
add some tests
transfer test from modal.spec. to scrollbar.spec
proper handling if style property doesn't exist
@XhmikosR XhmikosR changed the title Tests on scrollbar.js & better handling if a style property doesn't exists Add tests for scrollbar.js & better handling if a style property doesn't exist Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpadev alpadev alpadev approved these changes

Assignees
No one assigned
Labels
js tests v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeoSot @alpadev